----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33758/#review88227 -----------------------------------------------------------
tests/python/proton_tests/engine.py (line 1279) <https://reviews.apache.org/r/33758/#comment140636> Remove this tests/python/proton_tests/engine.py (line 2279) <https://reviews.apache.org/r/33758/#comment140637> remove this proton-c/bindings/python/proton/__init__.py (line 2489) <https://reviews.apache.org/r/33758/#comment140642> In python, it would be better to raise an exception here instead of returning None. The following code should work, but is totally untested :) if ssn is None: raise(SessionException("Session allocation failed --- blah blah blah") you'll also have to export SessionException by adding it to the __all__ array in that file. proton-c/include/proton/transport.h (line 335) <https://reviews.apache.org/r/33758/#comment140635> Rephrase to clarify: "Note that this is the maximum channel number allowed, giving a valid channel number range of [0..channel_max]. Therefore the maximum number of simultaineously active channels will be channel_max plus 1" tests/python/proton_tests/engine.py (line 254) <https://reviews.apache.org/r/33758/#comment140643> you can test for the SessionException here: try: ssn_1 = self.c2.session() assert False, "expected session exception" exception SessionException: pass again, totally untested... tests/python/proton_tests/engine.py (line 1279) <https://reviews.apache.org/r/33758/#comment140640> remove this tests/python/proton_tests/engine.py (line 2279) <https://reviews.apache.org/r/33758/#comment140639> Remove this - Kenneth Giusti On June 17, 2015, 5:45 a.m., michael goulish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33758/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 5:45 a.m.) > > > Review request for qpid, Kenneth Giusti and Ted Ross. > > > Repository: qpid-proton-git > > > Description > ------- > > PROTON-842 -- channels and sessions > > > Diffs > ----- > > proton-c/bindings/python/proton/__init__.py 9432bd8 > proton-c/include/proton/cproton.i ac2b121 > proton-c/include/proton/transport.h a3ca667 > proton-c/src/engine/engine-internal.h 4c72310 > proton-c/src/engine/engine.c c5228a5 > proton-c/src/transport/transport.c 0e23975 > tests/python/proton_tests/engine.py 924b3bc > > Diff: https://reviews.apache.org/r/33758/diff/ > > > Testing > ------- > > I originally did large system-testing using a broker and dispatch routers to > get 32K links through a single connection. > > This diff is based on what I did earlier, but improved (i think), and with a > couple mistakes corrected. Now I am testing only with proton unit tests > included with this diff, because latest dispatch is having an issue with > latest proton. > > > Thanks, > > michael goulish > >
