----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39173/#review102062 -----------------------------------------------------------
Ship it! Ideally we would modify the default value for service in Domain - ~line 222 of qpid/broker/amqp/Domain.cpp - which is used for broker initiated connections. That value can be set explicitly per domain, but since 1.0 defaulst to 'amqp' on the broker side it would be nice to change there as well. - Gordon Sim On Oct. 9, 2015, 3:33 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39173/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 3:33 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Bugs: QPID-6783 > https://issues.apache.org/jira/browse/QPID-6783 > > > Repository: qpid > > > Description > ------- > > See related JIRA > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1706484 > trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1706484 > trunk/qpid/cpp/src/qpid/broker/amqp/ProtocolPlugin.cpp 1706484 > trunk/qpid/cpp/src/qpid/messaging/ConnectionOptions.cpp 1706484 > > Diff: https://reviews.apache.org/r/39173/diff/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Kenneth Giusti > >
