----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39173/#review102254 -----------------------------------------------------------
trunk/qpid/cpp/src/qpid/broker/amqp/Domain.cpp (line 237) <https://reviews.apache.org/r/39173/#comment159834> Hrmmm... not sure I follow. There are 3 potential sources for the sasl service name. In priority: 1) passed via the domain create command option --sasl-service-name 2) lacking that, use the value configured via the broker wide configuration option --sasl-service-name 3) lacking that, default to 'amqp' If we remove the conditional, the code would ignore the broker configuration setting. - Kenneth Giusti On Oct. 9, 2015, 8:33 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39173/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 8:33 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Bugs: QPID-6783 > https://issues.apache.org/jira/browse/QPID-6783 > > > Repository: qpid > > > Description > ------- > > See related JIRA > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1706484 > trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1706484 > trunk/qpid/cpp/src/qpid/broker/amqp/Domain.cpp 1706484 > trunk/qpid/cpp/src/qpid/broker/amqp/ProtocolPlugin.cpp 1706484 > trunk/qpid/cpp/src/qpid/messaging/ConnectionOptions.cpp 1706484 > > Diff: https://reviews.apache.org/r/39173/diff/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Kenneth Giusti > >
