----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39173/#review102113 -----------------------------------------------------------
Ship it! Now that we have AMQP_SASL_SERVICENAME in a bunch of places we should really put the constant in a single place too. (But all these comments are mere quibbling) trunk/qpid/cpp/src/qpid/broker/amqp/Domain.cpp (line 225) <https://reviews.apache.org/r/39173/#comment159636> I think you could have the desired effect by only changing this to: ... service(AMQP_SASL_SERVICENAME) trunk/qpid/cpp/src/qpid/broker/amqp/Domain.cpp (line 237) <https://reviews.apache.org/r/39173/#comment159637> And reverting this change, since the previous code preset the name to "qpidd" via qpid::saslName, then allowed that to be overridden by the SASL_SERVICE property. In that case I think the complex new conditional is just unnecessary. - Andrew Stitcher On Oct. 9, 2015, 8:33 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39173/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 8:33 p.m.) > > > Review request for qpid, Andrew Stitcher and Gordon Sim. > > > Bugs: QPID-6783 > https://issues.apache.org/jira/browse/QPID-6783 > > > Repository: qpid > > > Description > ------- > > See related JIRA > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1706484 > trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1706484 > trunk/qpid/cpp/src/qpid/broker/amqp/Domain.cpp 1706484 > trunk/qpid/cpp/src/qpid/broker/amqp/ProtocolPlugin.cpp 1706484 > trunk/qpid/cpp/src/qpid/messaging/ConnectionOptions.cpp 1706484 > > Diff: https://reviews.apache.org/r/39173/diff/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Kenneth Giusti > >
