[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330041#comment-15330041
 ] 

ASF GitHub Bot commented on PROTON-1224:
----------------------------------------

Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/75#discussion_r67023365
  
    --- Diff: 
proton-j/src/test/resources/org/apache/qpid/proton/engine/impl/ssl/cert.pem.txt 
---
    @@ -0,0 +1,27 @@
    +-----BEGIN CERTIFICATE-----
    --- End diff --
    
    Please provide instructions on exactly how to (re)create the SSL resources 
used for the tests, so they can be easily updated later as needed.
    
    E.g like the existing proton SSL test resource details: 
https://github.com/apache/qpid-proton/blob/master/tests/python/proton_tests/ssl_db/README.txt
    Or the qpid-jms SSL test resource details (which can be sourced and execute 
directly): 
https://github.com/apache/qpid-jms/blob/master/qpid-jms-client/src/test/resources/README.txt


> Proton-J SSL uses deprecated Bouncy Castle functionality
> --------------------------------------------------------
>
>                 Key: PROTON-1224
>                 URL: https://issues.apache.org/jira/browse/PROTON-1224
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-j
>    Affects Versions: 0.12.2
>            Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to