[ https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330050#comment-15330050 ]
ASF GitHub Bot commented on PROTON-1224: ---------------------------------------- Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton/pull/75 I still need to have a final look, but if you could address the couple niggles I commented on that would be good. As I mentioned before, if you could also please remove merge commits from PRs that would be good, you have added a second in this version. Feel free to rebase the PR and squash all the commits, you don't need to open a new PR. > Proton-J SSL uses deprecated Bouncy Castle functionality > -------------------------------------------------------- > > Key: PROTON-1224 > URL: https://issues.apache.org/jira/browse/PROTON-1224 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j > Affects Versions: 0.12.2 > Reporter: Jem Day > > The BouncyCastle project deprecated functionality used by the proton-j driver > in version 1.48. This causes run-time issues for us as our application > containers are using newer BC versions. > I've submitted a PR for this change and verified that all tests run using > both BC 1.48 and 1.54. > Note: The CI pipeline for the PR is flagging an error but i am able to > build/test locally with no reported errors - build log is attached to the PR > comments. > https://github.com/apache/qpid-proton/pull/74 -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org