[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336943#comment-15336943
 ] 

ASF GitHub Bot commented on PROTON-1224:
----------------------------------------

Github user JemDay commented on the issue:

    https://github.com/apache/qpid-proton/pull/75
  
    i think this is royally screwed up now, the file-change list looks clean 
but using a rebase rather than a pull (to remove the merge commits) now appears 
to be having an even worse affect.
    
    I'm open to suggestions - i can close this PR, trash my fork, and then 
re-create the change if that's going to be a simpler path forward but before 
that i would like to better understand the fork/pull/commit/push/PR cycle when 
there may be multiple commits to the fork before the PR is actually raised. 
Squashing after commits have been pushed seems to just open world of hurt



> Proton-J SSL uses deprecated Bouncy Castle functionality
> --------------------------------------------------------
>
>                 Key: PROTON-1224
>                 URL: https://issues.apache.org/jira/browse/PROTON-1224
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-j
>    Affects Versions: 0.12.2
>            Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to