[
https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878082#comment-15878082
]
Lorenz Quack commented on QPID-7618:
------------------------------------
Review of the updated patch set:
* In {{ProducerFlowControlOverflowPolicyHandler}} would the
{{unblockIfUndefull(boolean forceUnblock)}} not be better modelled by a
{{unblockIfUnderfull}} which does the check and then calls {{unblock}} and
where you previously called {{unblockIfUndefull(true)}} you directly call
{{unblock}}? I see that logging would be an issue but maybe this could be
solved by merging the {{OVERFULL}} and {{OVERFULL_MESSAGES}} operational log
messages in a backwards compatible way. This would in part also address the
point I made about these messages.
* I see the problem you tried to solve by your changes to
{{RingOverflowPolicyHandler#handleOverflow}}. The consequence is that now we
will see a OVERFULL - UNDERFULL operational log pair for every enqueue. This
can be quite noisy. I am wondering whether reusing the operational log messages
makes sense here. I think it would be more interesting to log which or how many
messages have been deleted due to the {{RingOverflowPolicy}}.
> Ring policy type
> ----------------
>
> Key: QPID-7618
> URL: https://issues.apache.org/jira/browse/QPID-7618
> Project: Qpid
> Issue Type: New Feature
> Components: Java Broker
> Affects Versions: qpid-java-6.1.1, qpid-java-7.0
> Reporter: Tomas Vavricka
> Labels: policy-type, queue, ring
> Fix For: qpid-java-7.0
>
> Attachments: 0001-QPID-7569-Ring-policy-type.patch,
> overflow-policy.tar.gz
>
>
> It would be good if Java Broker will support ring policy.
> Ring policy - delete oldest message(s) when queue capacity is reached
> Queue capacity can be defined by maximum count of message and maximum size of
> messages (including header).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
