[
https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880894#comment-15880894
]
Alex Rudyy commented on QPID-7618:
----------------------------------
Lorenz,
I believe I addressed the majority of review comments and made commits.
The following are not addressed:
{quote}
Why was the validation in {{AbstractQueue#validateChange}} removed?
{quote}
I think we need to introduce context variable validation functionality in
order to validate all supported context variables rather than having some
bespoke validation logic scattered around various implementations of
configured objects.
{quote}
I think you misunderstood my comment about factoring out a method. You factored
out {{checkOverflow}} while I was talking about factoring out
{{checkUnderflow}}. So that you can avoid the calls to {{isUndefull}} when
called from the {{ProducerFlowControlListener}}.
{quote}
I do not think that it is necessary as the logic is {{checkUnderfull} is quite
simple to follow. IMHO, the introduction of a new method would make code more
complicated:)
{quote}
Why is the complication with checking the keys in
SortedQueueEntryList#getLastEntry needed? should it not be sufficient to just
iterate to the end of the list? Furthermore, I just discovered
QueueEntryList#getTail. Is this not exactly what we are trying to do with
QueueEntryList#getLastEntry?
{quote}
I renamed {{QueueEntryList#getLastEntry}} into
{{QueueEntryList#getLesserOldestEntry}}. For priority queue list it returns the
lowest priority oldest entry. For sorted queue list it returns the oldest entry
within entries having the same lowest key.
Implementation of SortedQueueEntryList#getTail traverse the list from head to
the last entry. That is exactly what implementation of
{{SortedQueueEntryList#getLesserOldestEntry}} does. If there are several
entries with the same key the newest is added to the end. Thus, we would need
to traverse from newest to oldest in order to get oldest one.
I have not changed the Broker documentation yet.
> Ring policy type
> ----------------
>
> Key: QPID-7618
> URL: https://issues.apache.org/jira/browse/QPID-7618
> Project: Qpid
> Issue Type: New Feature
> Components: Java Broker
> Affects Versions: qpid-java-6.1.1, qpid-java-7.0
> Reporter: Tomas Vavricka
> Labels: policy-type, queue, ring
> Fix For: qpid-java-7.0
>
> Attachments: 0001-QPID-7569-Ring-policy-type.patch,
> overflow-policy.tar.gz
>
>
> It would be good if Java Broker will support ring policy.
> Ring policy - delete oldest message(s) when queue capacity is reached
> Queue capacity can be defined by maximum count of message and maximum size of
> messages (including header).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
