[ 
https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880174#comment-15880174
 ] 

Alex Rudyy commented on QPID-7618:
----------------------------------

Lorenz,
I attached the updated patch bundle containing the new patch addressing the 
majority of your review comments.

I have not addressed the following:
{quote}
The changes in Queue.java break backwards compatibility and should be 
documented as such for the next release. This also means this should not go 
into 6.x. Interesting question: Do we need a versioning scheme for context 
variables?
{quote}
I'll add documentation later

I will not added the  review comment below which is unrelated to the changes I 
made
{quote}
It seems surprising that ServerMessage#isResourceAcceptable always returns true 
on 0-8 through 0-10 while on 1.0 it checks for delivery delay. Is that a bug?
{quote}



> Ring policy type
> ----------------
>
>                 Key: QPID-7618
>                 URL: https://issues.apache.org/jira/browse/QPID-7618
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Broker
>    Affects Versions: qpid-java-6.1.1, qpid-java-7.0
>            Reporter: Tomas Vavricka
>              Labels: policy-type, queue, ring
>             Fix For: qpid-java-7.0
>
>         Attachments: 0001-QPID-7569-Ring-policy-type.patch, 
> overflow-policy.tar.gz, overflow-policy.tar.gz
>
>
> It would be good if Java Broker will support ring policy.
> Ring policy - delete oldest message(s) when queue capacity is reached
> Queue capacity can be defined by maximum count of message and maximum size of 
> messages (including header).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to