[ 
https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885433#comment-15885433
 ] 

Keith Wall commented on QPID-7618:
----------------------------------

A couple of comments:

# Upgrading from 6.1 with a queue with a producer flow control defined causes a 
stack trace.   Upgrade assumes camel cased names.
# The UI uses the screen label "Maximum Queue Depth including headers" but this 
disagrees with the {ProducerFlowControlOverflowPolicyHandler} imply which uses 
{{queueDepthBytes}} rather than {{queueDepthBytesIncludingHeader}}.  I think 
PFC should consider the header even though this will be a change  in behaviour 
from previous versions.  
# After upgrade, for queue with no policy, on edit the dialogue makes the 
policy attribute field in error and forces me to change it back to None.
# The -1s in the queue show tab are confusing.  How is a user supposed to know 
what this means?
# The method name Queue#getLesserOldestEntry communicates nothing to me.   
Furthermore, I don't think the Queue API in general should have this concern.  
This is something particular to ring queue policy so the responsibility for 
implementing the delete should reside with it.   Personally, I find the current 
behaviour of ring policy with sorted queues surprising.  If sorted queue types 
are to support the ring policy, I'd prefer if they just purged the eldest entry.


{noformat}
java.lang.NullPointerException: null
at 
org.apache.qpid.server.queue.AbstractQueue.getOldestMessageArrivalTime(AbstractQueue.java:1406)
~[classes/:na]
at 
org.apache.qpid.server.queue.AbstractQueue.getOldestMessageAge(AbstractQueue.java:1444)
~[classes/:na]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_111]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[na:1.8.0_111]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[na:1.8.0_111]
at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_111]
at 
org.apache.qpid.server.model.ConfiguredObjectMethodAttributeOrStatistic.getValue(ConfiguredObjectMethodAttributeOrStatistic.java:68)
~[classes/:na]
at 
org.apache.qpid.server.model.ConfiguredObjectMethodStatistic.getValue(ConfiguredObjectMethodStatistic.java:26)
~[classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject.getStatistics(AbstractConfiguredObject.java:3159)
~[classes/:na]
at 
org.apache.qpid.server.queue.StandardQueueImplWithAccessChecking.getStatistics(StandardQueueImplWithAccessChecking.java:46)
~[classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject.getStatistics(AbstractConfiguredObject.java:3146)
~[classes/:na]
at 
org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateStatisticsIntoMap(ConfiguredObjectToMapConverter.java:218)
~[classes/:na]
at 
org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:65)
~[classes/:na]
at 
org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateChildrenIntoMap(ConfiguredObjectToMapConverter.java:271)
~[classes/:na]
at 
org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:69)
~[classes/:na]
at 
org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGet(RestServlet.java:301)
~[classes/:na]
at 
org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doGet(AbstractServlet.java:123)
~[classes/:na]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:575)
~[geronimo-servlet_3.0_spec-1.0.jar:1.0]
{noformat}




> Ring policy type
> ----------------
>
>                 Key: QPID-7618
>                 URL: https://issues.apache.org/jira/browse/QPID-7618
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Broker
>    Affects Versions: qpid-java-6.1.1, qpid-java-7.0
>            Reporter: Tomas Vavricka
>            Assignee: Alex Rudyy
>              Labels: policy-type, queue, ring
>             Fix For: qpid-java-7.0
>
>         Attachments: 0001-QPID-7569-Ring-policy-type.patch
>
>
> It would be good if Java Broker will support ring policy.
> Ring policy - delete oldest message(s) when queue capacity is reached
> Queue capacity can be defined by maximum count of message and maximum size of 
> messages (including header).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to