Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/99#discussion_r107257116 --- Diff: proton-c/src/core/transport.c --- @@ -1619,6 +1619,17 @@ static int pn_scan_error(pn_data_t *data, pn_condition_t *condition, const char return 0; } +/* + This operator, copied from code for the qpid cpp broker, gives the correct + result when comparing sequence numbers implemented in a signed integer type. +*/ +static bool sequence_less_than ( pn_sequence_t a, pn_sequence_t b ) --- End diff -- ie code would be static int sequence_cmp(pn_sequence_t a, pn_sequence_t b) { return a-b; }
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org