Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/99#discussion_r107258218
--- Diff: proton-c/src/core/transport.c ---
@@ -1648,7 +1659,7 @@ int pn_do_disposition(pn_transport_t *transport,
uint8_t frame_type, uint16_t ch
bool remote_data = (pn_data_next(transport->disp_data) &&
pn_data_get_list(transport->disp_data) > 0);
- for (pn_sequence_t id = first; id <= last; id++) {
+ for (pn_sequence_t id = first; sequence_less_than(id, last) || (id ==
last); id++) {
--- End diff --
Of course this test will still do the wrong thing if the wrap-around is big
enough (ie if first > last at teh start of the loop)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
