Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/99
Having looked a bit more it seems less clear that the bug is in pn_hash!
Essentially the lower 32 bit masking is used as a more determinate way to
cast the int32_t of the pn_sequence_t to the uintptr_t (uint64_t) of the hash
code I don't understand (yet) why this casting sometimes gives different
results, but I *strongly suggest* creating a better named inline function to
express the intent rather than doing the masking with no real explanation.
Viz:
static inline uintptr_t pni_sequence_make_hash(pn_sequence_t i) {
return i & 0xFFFFFFFFUL;
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
