[ 
https://issues.apache.org/jira/browse/PROTON-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418043#comment-16418043
 ] 

Alan Conway commented on PROTON-1809:
-------------------------------------

[~gemmellr] called it: bogus calculation of session incoming-window, which was 
always being computed as 0 if max-frame > session-capacity. Please take a look 
at this proposed fix:

[https://github.com/alanconway/qpid-proton/commit/118be92f]

According to this comment in proton/session.h, the fixed behavior was intended 
but not implemented.

/**
 * The incoming capacity of a session determines how much incoming
 * message data the session will buffer. Note that if this value is
 * less than the negotiated frame size of the transport, it will be
 * rounded up to one full frame.
 */

> [python, ruby] Unable to receive messages when max-frame-size is set to more 
> than 2^20
> --------------------------------------------------------------------------------------
>
>                 Key: PROTON-1809
>                 URL: https://issues.apache.org/jira/browse/PROTON-1809
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding, ruby-binding
>    Affects Versions: proton-c-0.22.0
>         Environment: RHEL 7 x86_64
>            Reporter: Radim Kubis
>            Assignee: Alan Conway
>            Priority: Minor
>
> *Python:*
> {code:java}
>   def on_session_init(self, event):
>      event.transport._set_max_frame_size(VALUE)
> {code}
> I noticed that the receiver is not able to receive messages when the value 
> for max-frame-size is larger than 2^20 (1048576) bytes (remote_max_frame_size 
> is 4294967295). I'm not really sure if that is expected. This may be 
> reproduced when adding the code above ie.: to simple_recv.py.
> Note: This is not a good use case as setting the max-frame-size in 
> on_session_init is really too late. But given that it is too late to set the 
> max-frame-size, I would expect it won't have any effect on the client.
>  
> *Ruby:*
> From [https://github.com/rh-messaging/cli-proton-ruby] 
> [cli-proton-ruby|https://github.com/rh-messaging/cli-proton-ruby]
> {{cli-proton-ruby-receiver -b <broker> -c <msg_count> --log-msgs dict 
> --conn-max-frame-size 1048577}}
> Receiver is stuck.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to