[
https://issues.apache.org/jira/browse/PROTON-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418787#comment-16418787
]
Robbie Gemmell commented on PROTON-1809:
----------------------------------------
I have reverted the change to remove it from 0.22.0. This is very long-standing
issue with relatively minor chance anyone new will hit it, it can wait for
0.23.0.
I don't think the approach taken of silently adjusting and exceeding the
requested session capacity is correct. In some ways it would be worse than the
automagic effect that changing frame size had on the session window handling
previously. Doing so would hide a fundamental issue in the usage, and result in
likely undesired single-frame session window that will give poor performance in
all but the simplest cases. People setting the session capacity and frame size
explicitly really need to understand what that means, and that the former cant
be smaller than the latter if they want to receive anything and actually govern
session capacity. We can actively prevent them configuring it that way if
desired, though some doc text would suffice for me.
Definitely needs some tests adding.
PROTON-636 needs updated as well, linked it for now.
> [python, ruby] Unable to receive messages when max-frame-size is set to more
> than 2^20
> --------------------------------------------------------------------------------------
>
> Key: PROTON-1809
> URL: https://issues.apache.org/jira/browse/PROTON-1809
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding, ruby-binding
> Affects Versions: proton-c-0.22.0
> Environment: RHEL 7 x86_64
> Reporter: Radim Kubis
> Assignee: Alan Conway
> Priority: Minor
> Fix For: proton-c-0.23.0
>
>
> *Python:*
> {code:java}
> def on_session_init(self, event):
> event.transport._set_max_frame_size(VALUE)
> {code}
> I noticed that the receiver is not able to receive messages when the value
> for max-frame-size is larger than 2^20 (1048576) bytes (remote_max_frame_size
> is 4294967295). I'm not really sure if that is expected. This may be
> reproduced when adding the code above ie.: to simple_recv.py.
> Note: This is not a good use case as setting the max-frame-size in
> on_session_init is really too late. But given that it is too late to set the
> max-frame-size, I would expect it won't have any effect on the client.
>
> *Ruby:*
> From [https://github.com/rh-messaging/cli-proton-ruby]
> [cli-proton-ruby|https://github.com/rh-messaging/cli-proton-ruby]
> {{cli-proton-ruby-receiver -b <broker> -c <msg_count> --log-msgs dict
> --conn-max-frame-size 1048577}}
> Receiver is stuck.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
