ASF subversion and git services commented on PROTON-1809:

Commit e8de49d33b1c750327e6c9a090332953a7669a4d in qpid-proton's branch 
refs/heads/go1 from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e8de49d ]

PROTON-1809: Unable to receive messages when max-frame-size > 2^20

The C transport code was computing the session incoming window as
session_capacity/max_frame_size, resulting in an incoming window that was always
0 if the frame size was bigger than session_capacity (default 2^20)


1. Removed the default session-capacity. Session flow control is only enabled
   if session-capacity and max-frame-size are *both* explicitly set.

2. If the specified session capacity is less than max-frame-size, it is
   automatically increased to be equal to max-frame-size to ensure at least one
   frame can be received.

> [python, ruby] Unable to receive messages when max-frame-size is set to more 
> than 2^20
> --------------------------------------------------------------------------------------
>                 Key: PROTON-1809
>                 URL: https://issues.apache.org/jira/browse/PROTON-1809
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding, ruby-binding
>    Affects Versions: proton-c-0.22.0
>         Environment: RHEL 7 x86_64
>            Reporter: Radim Kubis
>            Assignee: Alan Conway
>            Priority: Minor
>             Fix For: proton-c-0.23.0
> *Python:*
> {code:java}
>   def on_session_init(self, event):
>      event.transport._set_max_frame_size(VALUE)
> {code}
> I noticed that the receiver is not able to receive messages when the value 
> for max-frame-size is larger than 2^20 (1048576) bytes (remote_max_frame_size 
> is 4294967295). I'm not really sure if that is expected. This may be 
> reproduced when adding the code above ie.: to simple_recv.py.
> Note: This is not a good use case as setting the max-frame-size in 
> on_session_init is really too late. But given that it is too late to set the 
> max-frame-size, I would expect it won't have any effect on the client.
> *Ruby:*
> From [https://github.com/rh-messaging/cli-proton-ruby] 
> [cli-proton-ruby|https://github.com/rh-messaging/cli-proton-ruby]
> {{cli-proton-ruby-receiver -b <broker> -c <msg_count> --log-msgs dict 
> --conn-max-frame-size 1048577}}
> Receiver is stuck.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to