[
https://issues.apache.org/jira/browse/DISPATCH-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592057#comment-16592057
]
ASF GitHub Bot commented on DISPATCH-1103:
------------------------------------------
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/366#discussion_r212715743
--- Diff: src/router_core/connections.c ---
@@ -1753,6 +1756,12 @@ static void qdr_link_inbound_detach_CT(qdr_core_t
*core, qdr_action_t *action, b
link->auto_link->state = QDR_AUTO_LINK_STATE_FAILED;
free(link->auto_link->last_error);
link->auto_link->last_error = qdr_error_description(error);
+
+ //
+ // The auto link has failed. Periodically retry setting up the
auto link until
+ // it succeeds.
+ //
+ qdr_route_retry_auto_link_CT(core, link);
--- End diff --
Same comment here: At this location in the architecture, the fact that
there is a retry is abstracted. This call should be "auto_link_detached" or
similar. Let the route_control module be responsible for what actions it takes
when an auto-link is detached by the peer.
> auto-links should retry after detach
> ------------------------------------
>
> Key: DISPATCH-1103
> URL: https://issues.apache.org/jira/browse/DISPATCH-1103
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
> Affects Versions: 1.3.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> When an auto-link is activated, it attempts to attach to a node on the remote
> container. If this attach fails, or succeeds and subsequently gets detached,
> the auto-link will remain in the failed state until it is later re-activated.
> Active auto-links that fail to attach or become detached should periodically
> attempt to reattach to the remote node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
