[
https://issues.apache.org/jira/browse/DISPATCH-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592059#comment-16592059
]
ASF GitHub Bot commented on DISPATCH-1103:
------------------------------------------
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/366#discussion_r212715250
--- Diff: src/router_core/connections.c ---
@@ -1329,6 +1329,9 @@ static void qdr_connection_closed_CT(qdr_core_t
*core, qdr_action_t *action, boo
while (link_ref) {
qdr_link_t *link = link_ref->link;
+ if (link->auto_link && link->auto_link->retry_timer)
+ qdr_core_timer_cancel_CT(core, link->auto_link->retry_timer);
--- End diff --
The fact that there is a retry-timer in the auto-link is an implementation
detail that should not be visible at this level. It would be better to have a
call in the route_control module for "auto_link_connection_closed" or similar.
> auto-links should retry after detach
> ------------------------------------
>
> Key: DISPATCH-1103
> URL: https://issues.apache.org/jira/browse/DISPATCH-1103
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
> Affects Versions: 1.3.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> When an auto-link is activated, it attempts to attach to a node on the remote
> container. If this attach fails, or succeeds and subsequently gets detached,
> the auto-link will remain in the failed state until it is later re-activated.
> Active auto-links that fail to attach or become detached should periodically
> attempt to reattach to the remote node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
