[ 
https://issues.apache.org/jira/browse/DISPATCH-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592058#comment-16592058
 ] 

ASF GitHub Bot commented on DISPATCH-1103:
------------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/366#discussion_r212714631
  
    --- Diff: src/router_core/route_control.h ---
    @@ -43,6 +43,13 @@ qdr_auto_link_t *qdr_route_add_auto_link_CT(qdr_core_t   
       *core,
                                                 qd_parsed_field_t      
*connection_field,
                                                 qd_parsed_field_t   
*external_addr);
     
    +/**
    + * Attempts re-establishing auto links across the related 
connections/containers
    + * @param core Pointer to the core object returned by qd_core()
    + * @param context - the auto link that needs to be activated
    + */
    +void qdr_route_attempt_auto_link_CT(qdr_core_t      *core, void   
*context);
    --- End diff --
    
    This is not part of the route_control API.  It is simply an internal helper 
within the module.  It should be removed from the header file (API) and made 
static in the source file.


> auto-links should retry after detach
> ------------------------------------
>
>                 Key: DISPATCH-1103
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1103
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.3.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>
> When an auto-link is activated, it attempts to attach to a node on the remote 
> container. If this attach fails, or succeeds and subsequently gets detached, 
> the auto-link will remain in the failed state until it is later re-activated.
> Active auto-links that fail to attach or become detached should periodically 
> attempt to reattach to the remote node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to