[
https://issues.apache.org/jira/browse/PROTON-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721807#comment-16721807
]
Alan Conway commented on PROTON-985:
------------------------------------
Easiest. Fix. Ever.
transport_tick always needed to be fed from a monotonic clock, changed the
parameter type and updated the docs to make that clear.
> Modify pn_transport_tick to explicitly use a monotonic clock, not wall clock
> time
> ---------------------------------------------------------------------------------
>
> Key: PROTON-985
> URL: https://issues.apache.org/jira/browse/PROTON-985
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-0.10
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: proton-c-future
>
>
> The timestamp argument to pn_transport_tick is a pn_timestamp_t.
> pn_timestamp_t implies real time (wall clock) in that it's expressed as a
> time value based on epoch.
> As seen in QPID-6698, using a real time value for that argument can lead to
> problems if the real time is adjusted (eg. timezone, daylight savings,
> drift).
> Instead, pn_transport_tick should be passed a monotonic clock source - one
> that does not reflect changes in real time.
> All documentation and examples should be updated accordingly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
