[
https://issues.apache.org/jira/browse/PROTON-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722951#comment-16722951
]
Robbie Gemmell commented on PROTON-985:
---------------------------------------
Various build failures in CI, as below. Also, seems fairly unlikely there are
no usages of the API you changed that wouldnt also need updating to actually
supply a monotonic clock, if only as example?
[https://travis-ci.org/apache/qpid-proton/builds/468194286]
{noformat}
Scanning dependencies of target go-src-link
[ 98%] Built target go-src-link
Scanning dependencies of target go-build
# qpid.apache.org/proton
go/src/qpid.apache.org/proton/wrappers_gen.go:862: cannot use pnTime(now) (type
C.pn_timestamp_t) as type C.int64_t in argument to _Cfunc_pn_transport_tick
make[2]: *** [go/CMakeFiles/go-build] Error 2
make[1]: *** [go/CMakeFiles/go-build.dir/all] Error 2
make: *** [all] Error 2
The command "cmake --build . --target install && ctest -V
${QPID_PROTON_CTEST_ARGS}" exited with 2.
{noformat}
> Modify pn_transport_tick to explicitly use a monotonic clock, not wall clock
> time
> ---------------------------------------------------------------------------------
>
> Key: PROTON-985
> URL: https://issues.apache.org/jira/browse/PROTON-985
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-0.10
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: proton-c-future
>
>
> The timestamp argument to pn_transport_tick is a pn_timestamp_t.
> pn_timestamp_t implies real time (wall clock) in that it's expressed as a
> time value based on epoch.
> As seen in QPID-6698, using a real time value for that argument can lead to
> problems if the real time is adjusted (eg. timezone, daylight savings,
> drift).
> Instead, pn_transport_tick should be passed a monotonic clock source - one
> that does not reflect changes in real time.
> All documentation and examples should be updated accordingly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
