[ 
https://issues.apache.org/jira/browse/PROTON-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764137#comment-16764137
 ] 

Jiri Daněk commented on PROTON-985:
-----------------------------------

[~aconway] [~gemmellr] This looks to me to be done in what's to be proton-c 
0.27.0. Do you know what more is to do here?

I am guessing there might be some work left in other bindings besides Go and 
the issue summary also suggests

> All documentation and examples should be updated accordingly.

Regarding compatibility, pn_timestamp_t was/is an alias for int64_t, so there 
should not be problem. Except in Go, as was seen in second commit above, which 
is more strict regarding auto casting.

> Modify pn_transport_tick to explicitly use a monotonic clock, not wall clock 
> time
> ---------------------------------------------------------------------------------
>
>                 Key: PROTON-985
>                 URL: https://issues.apache.org/jira/browse/PROTON-985
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: proton-0.10
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Major
>             Fix For: proton-c-future
>
>
> The timestamp argument to pn_transport_tick is a pn_timestamp_t.  
> pn_timestamp_t implies real time (wall clock) in that it's expressed as a 
> time value based on epoch.
> As seen in QPID-6698, using a real time value for that argument can lead to 
> problems if the real time is adjusted (eg.  timezone, daylight savings, 
> drift).
> Instead, pn_transport_tick should be passed a monotonic clock source - one 
> that does not reflect changes in real time.
> All documentation and examples should be updated accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to