tabish121 commented on issue #30: PROTON-1998: Add SASL protocol trace URL: https://github.com/apache/qpid-proton-j/pull/30#issuecomment-459768206 I'd tend to agree with @gemmellr that the change should be more targeted and not alter the TransportFrame at this point. Also I'm wondering is we want to default the not logging SASL frames unless configured to as it does expose that data where it was not doing so before which could be surprising to some. It probably isn't a huge deal as the bytes can be seen anyway and possibly logged by other frameworks... I guess proton-c just logs all of it now so being consistent isn't a terrible thing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
