[ 
https://issues.apache.org/jira/browse/PROTON-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773225#comment-16773225
 ] 

ASF GitHub Bot commented on PROTON-1936:
----------------------------------------

astitcher commented on issue #156: PROTON-1936: lower case include and updated 
ifdefs
URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465677673
 
 
   You don't explain what problem you are solving with these changes. Please 
give more details about why you need to -
   1. change the case of the includes - I thought windows filesystems are case 
insensitive.
   2. Add some platform detection as well as compiler detection - I think that 
in openssl.c the detection should probably be platform detection instead of 
compiler detection. But in the other cases it platform detection makes no sense 
to me as things being selected are compiler things not platform things.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support cross compiling to Windows from Linux
> ---------------------------------------------
>
>                 Key: PROTON-1936
>                 URL: https://issues.apache.org/jira/browse/PROTON-1936
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: proton-c-0.25.0
>            Reporter: Marcel Meulemans
>            Priority: Minor
>
> I am cross compiling proton for Windows via docker (multiarch/crossbuild) and 
> running into a few minor issues that make it not work out of the box (mainly 
> include file casing). Pull request will follow, more details there ... it 
> would be nice if this made it upstream.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to