[ 
https://issues.apache.org/jira/browse/PROTON-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773444#comment-16773444
 ] 

ASF GitHub Bot commented on PROTON-1936:
----------------------------------------

astitcher commented on issue #156: PROTON-1936: lower case include and updated 
ifdefs
URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465779208
 
 
   Having said all that on the whole if the Windows CI build works and the 
Linux CI build is unaffected I'm ok with merging this change. I'd just prefer 
to make the platform/compiler selection logic as simple and clear as possible, 
without explanationless voodoo present.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support cross compiling to Windows from Linux
> ---------------------------------------------
>
>                 Key: PROTON-1936
>                 URL: https://issues.apache.org/jira/browse/PROTON-1936
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: proton-c-0.25.0
>            Reporter: Marcel Meulemans
>            Priority: Minor
>
> I am cross compiling proton for Windows via docker (multiarch/crossbuild) and 
> running into a few minor issues that make it not work out of the box (mainly 
> include file casing). Pull request will follow, more details there ... it 
> would be nice if this made it upstream.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to