ted-ross commented on a change in pull request #453: DISPATCH-1278: initial
support for prometheus metrics export
URL: https://github.com/apache/qpid-dispatch/pull/453#discussion_r262996925
##########
File path: src/http-libwebsockets.c
##########
@@ -361,6 +386,135 @@ static void connection_wake(qd_connection_t *qd_conn)
}
}
+static void handle_stats_results(void *context, qdr_global_stats_t *results)
+{
+ stats_t* stats = (stats_t*) context;
+ qd_http_server_t *hs = stats->server;
+ if (hs) {
+ work_t w = { W_HANDLE_STATS, stats->wsi };
+ work_push(hs, w);
Review comment:
It should be noted that this handler is being called on the core-thread.
Since work_push can block on a condition, the core thread is at risk for being
blocked by the HTTP processing. It might be better for the core-thread to
schedule this callback as a general-work item so it runs on an I/O thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
