ted-ross commented on a change in pull request #453: DISPATCH-1278: initial 
support for prometheus metrics export
URL: https://github.com/apache/qpid-dispatch/pull/453#discussion_r263047011
 
 

 ##########
 File path: src/http-libwebsockets.c
 ##########
 @@ -361,6 +386,135 @@ static void connection_wake(qd_connection_t *qd_conn)
     }
 }
 
+static void handle_stats_results(void *context, qdr_global_stats_t *results)
+{
+    stats_t* stats = (stats_t*) context;
+    qd_http_server_t *hs = stats->server;
+    if (hs) {
+        work_t w = { W_HANDLE_STATS, stats->wsi };
+        work_push(hs, w);
 
 Review comment:
   Sorry, I meant to not even use an action for the core thread.  Just go read 
the current values of the counters from the HTTP thread, ignoring any glitches 
that occur as a result of concurrency.
   
   If you use the general-work method, the call is qdr_post_general_work.  I 
think there's a void* you can use to point to the metric object and you can add 
fields to qdr_general_work_t if needed.  You of course need to write the 
I/O-thread-side work function that calls the metric callback.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to