ChugR commented on issue #503: DISPATCH-974 - Added code to qdstat and qdmanage clients to repeatedl… URL: https://github.com/apache/qpid-dispatch/pull/503#issuecomment-490593232 +1 the implementation looks OK and the tests pass. The technique used here, pulling successive slices on repeated calls, leaves room for the underlying list in proton to change between calls. This could lead to duplicate or missing entries. Is there a place to put doc text explaining this so that users' expectations are properly framed when the lists are longer than the 700 entries?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
