alanconway edited a comment on issue #182: PROTON-2040: Alternative suggestion for updating connection options: URL: https://github.com/apache/qpid-proton/pull/182#issuecomment-490608572 This looks good to me. On initial URL I noticed that also. We could make URL a connection_option and provide a connect() that takes only options - I think we do that in some other bindings like ruby. If you use a connect(url, opts) call, then I would say the URL from connect() should over-write any URL in the options to avoid confusion. Either that or it would be an error to have a URL in the options when calling connect(url, opts)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
