stsiano commented on issue #32: QPIDJMS-441: add proxy support URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-540538542 Your approach is of course also fine, but it makes using the interface a bit awkward. Furthermore the proxy is not optional with your implementation as you have a NettyTcpTransport class still depends on the ProxyHandler class (however you could use a ChannelHandler or a ChannelOutboundHandler instead (the ProxyHandler implements these interfaces)). Shall I update my change accordingly? TLS/SSL works over a proxy. I will start working on the tests when I find the time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
