stsiano commented on issue #32: QPIDJMS-441: add proxy support URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-545858277 I have created another version of the pull request. Here the test proxy implementation is duplicated (in qpid-jms-client and qpid-jms-activemq-tests). Maybe it would be better to move this to a separate module (e.g. qpid-jms-tests-helper) and import that as a test dependency in both modules (the proxy code has slf4j-api as its only dependency). Aside from that I would consider this closer to completion now. I also found something that does not work: amqp+wss does not work with a HTTP proxy (it works with a Socks Proxy). This is actually an unresolved Netty issue: https://github.com/netty/netty/issues/5201 The HTTP proxy handler adds another HttpClientCodec at the beginning of the pipeline. (so there are actually two HttpClientCodecs in the pipeline. This confuses the WebSocketClientHandshaker to add the ws-encoder and ws-decoder at the wrong place in the pipeline. For some reason I don't really understand this still works without TLS, but a wss connection collapses after the web socket conversion. This should work if the issue ever gets fixed in Netty, but right now I don't have a good solution to get this combination running. I also think that this feature is useful enough without this combination.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
