kgiusti commented on a change in pull request #641: DISPATCH-1514 - Dynamically
turned on proton frame trace on existing …
URL: https://github.com/apache/qpid-dispatch/pull/641#discussion_r356770898
##########
File path: src/log.c
##########
@@ -541,7 +542,16 @@ qd_error_t qd_log_entity(qd_entity_t *entity) {
if (qd_entity_has(entity, "enable")) {
enable = qd_entity_get_string(entity, "enable");
QD_ERROR_BREAK();
+
src->mask = enable_mask(enable);
+
+ //
+ // If trace logging is enabled, loop thru all connections in the
router and call the pn_transport_set_tracer callback
+ // so proton frame trace can be output as part of the router trace
log.
+ //
+ if (qd_log_enabled(src, QD_LOG_TRACE)) {
Review comment:
would it be possible to move this outside of the log_source_lock? For
example, just set a flag here then check the flag after dropping the lock and
making the call to qd_server_trace_all_connections() then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
