kgiusti commented on a change in pull request #641: DISPATCH-1514 - Dynamically
turned on proton frame trace on existing …
URL: https://github.com/apache/qpid-dispatch/pull/641#discussion_r356770256
##########
File path: src/server.c
##########
@@ -1276,6 +1277,25 @@ void qd_server_set_container(qd_dispatch_t *qd,
qd_container_t *container)
qd->server->container = container;
}
+void qd_server_trace_all_connections()
+{
+ qd_dispatch_t *qd = qd_dispatch_get_dispatch();
+ if (qd->server) {
+ qd_connection_list_t conn_list = qd->server->conn_list;
+ qd_connection_t *conn = DEQ_HEAD(conn_list);
+ while(conn) {
Review comment:
the qd->server->conn_list is protected by qd->server->lock. this loop will
need to hold that lock while walking the list or it is possible the connection
it is working on is removed (and possibly freed) by another thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
