kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed
router crash when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r366935052
##########
File path: src/http-libwebsockets.c.in
##########
@@ -354,7 +354,7 @@ static void listener_start(qd_http_listener_t *hl,
qd_http_server_t *hs) {
info.options |=
LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
- (config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT) |
+ (config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT
${OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER}) |
Review comment:
libwebsockets exports its version as the following:
LWS_LIBRARY_VERSION_MAJOR
LWS_LIBRARY_VERSION_MINOR
you should be able to simply do
#if LWS_LIBRARY_VERSION_MAJOR > 3 || (LWS_LIBRARY_VERSION_MAJOR == 3 &&
LWS_LIBRARY_VERSION_MINOR >= 2)
set the HTTPS_ON_HTTPS_LISTENER flags etc
#endif
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
