ChugR commented on a change in pull request #660: DISPATCH-1513 - Fixed router
crash when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367075938
##########
File path: tests/system_tests_http.py.in
##########
@@ -250,8 +250,9 @@ def listener(**kwargs):
self.assert_get("https://localhost:%s"; % r.ports[0])
# requireSsl=false Allows simple-ssl HTTP
- # Commenting out the following assert until DISPATCH-1513 is fixed.
- #self.assert_get("http://localhost:%s"; % r.ports[0])
+ # The following test will be commented out if you are runnung a
version lower than
Review comment:
These are compile-time tests that build software with or without some
features. Don't we really want code that is compiled to handle both cases and
then detect what to do at run-time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
