ganeshmurthy commented on a change in pull request #668: DISPATCH-1509: free
core agent timer on shutdown
URL: https://github.com/apache/qpid-dispatch/pull/668#discussion_r368699431
##########
File path: src/router_core/agent.c
##########
@@ -39,27 +39,40 @@ static void qdr_manage_update_CT(qdr_core_t *core,
qdr_action_t *action, bool di
ALLOC_DECLARE(qdr_query_t);
ALLOC_DEFINE(qdr_query_t);
+
+struct qdr_agent_t {
Review comment:
since the object is already called qdr_agent_t is it redundant to have the
word agent for its members ? For example, agent->agent_response_handler can
just be called agent->response_handler, same with agent_subscription_mobile,
agent_subscription_mobile, agent_subscription_local and agent_log_source
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
