ganeshmurthy commented on a change in pull request #668: DISPATCH-1509: free 
core agent timer on shutdown
URL: https://github.com/apache/qpid-dispatch/pull/668#discussion_r368701027
 
 

 ##########
 File path: src/router_core/router_core_private.h
 ##########
 @@ -800,15 +801,7 @@ struct qdr_core_t {
     qdrc_attach_addr_lookup_t  addr_lookup_handler;
     void                      *addr_lookup_context;
 
-    //
-    // Agent section
-    //
-    qdr_query_list_t       outgoing_query_list;
-    sys_mutex_t           *query_lock;
-    qd_timer_t            *agent_timer;
-    qdr_manage_response_t  agent_response_handler;
-    qdr_subscription_t    *agent_subscription_mobile;
-    qdr_subscription_t    *agent_subscription_local;
+    qdr_agent_t               *agent;
 
 Review comment:
   I wonder if this should be mgmt_agent instead of just agent because it is 
used to respond exclusively to management requests coming in on $management

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to