ChugR commented on a change in pull request #717: DISPATCH-975: Enforce max message size on message ingress URL: https://github.com/apache/qpid-dispatch/pull/717#discussion_r408943777
########## File path: src/amqp.c ########## @@ -86,6 +86,7 @@ const char * const QD_AMQP_COND_RESOURCE_DELETED = "amqp:resource-deleted"; const char * const QD_AMQP_COND_ILLEGAL_STATE = "amqp:illegal-state"; const char * const QD_AMQP_COND_FRAME_SIZE_TOO_SMALL = "amqp:frame-size-too-small"; const char * const QD_AMQP_COND_CONNECTION_FORCED = "amqp:connection:forced"; +const char * const QD_AMQP_COND_MESSAGE_SIZE_EXCEEDED = "amqp:connection:message-size-exceeded"; Review comment: Earlier versions of this feature tried closing the link with an error. This did not work well with any of the proton clients, in particular the python client used by dispatch self tests. See https://issues.apache.org/jira/browse/PROTON-2182 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
