gemmellr commented on a change in pull request #717: DISPATCH-975: Enforce max message size on message ingress URL: https://github.com/apache/qpid-dispatch/pull/717#discussion_r409020190
########## File path: src/amqp.c ########## @@ -86,6 +86,7 @@ const char * const QD_AMQP_COND_RESOURCE_DELETED = "amqp:resource-deleted"; const char * const QD_AMQP_COND_ILLEGAL_STATE = "amqp:illegal-state"; const char * const QD_AMQP_COND_FRAME_SIZE_TOO_SMALL = "amqp:frame-size-too-small"; const char * const QD_AMQP_COND_CONNECTION_FORCED = "amqp:connection:forced"; +const char * const QD_AMQP_COND_MESSAGE_SIZE_EXCEEDED = "amqp:connection:message-size-exceeded"; Review comment: To be clearer, I was talking about the sending link, vs sending connection. In this case the example having both the sender and receiver of the message on the same connection probably confuses matters a touch. From the error and stacktrace that appears to be more on the receiver side. Perhaps a general issue with handling aborted deliveries? Unclear it relates to choice of whether to close the sending link vs connection, other than the fact both are on the same connection. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
