ted-ross edited a comment on pull request #744: URL: https://github.com/apache/qpid-dispatch/pull/744#issuecomment-635039909
On Wed, May 27, 2020 at 10:53 AM Chuck Rolke <notificati...@github.com> wrote: > *@ChugR* commented on this pull request. > ------------------------------ > > In src/connection.h > <https://github.com/apache/qpid-dispatch/pull/744#discussion_r431199344>: > > > + qd_timer_t* timer; // Timer for initial setup > + pn_connection_t* pn_conn; > + pn_session_t* pn_sessions[QD_SSN_CLASS_COUNT]; > + pn_ssl_t* ssl; > + qd_listener_t* listener; > + qd_connector_t* connector; > > By and large the format convention for existing code is to have the > indirection operator close to the variable name and not close to the type > name. Is there a reason for changing this? > Attaching the operator to the variable name helps one to reason correctly > about the variable's type when multiple variables are declared on the same > line. > Please do this the way Chuck suggests: ``` qd_timer_t *timer; int count; ``` This is the convention used throughout the code. Thanks, -Ted > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/qpid-dispatch/pull/744#pullrequestreview-419303375>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAFEKJSFFU4M3FQ72NWYHHLRTUSNPANCNFSM4NJ2LRBQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
