gemmellr commented on pull request #744: URL: https://github.com/apache/qpid-dispatch/pull/744#issuecomment-635209564
On the flipside, for something like this I far prefer updating the single PR (even with force pushes) than opening lots of new PRs and spreading related discussion over a bunch of them. If that discussion starts off saying 'this is just wrong, lets do some other entirely different thing, fix the actual problem, rather than whatever this does', then perhaps a new PR might be more appropriate. Essentially, I think of PR branches in a repo fork as all but private unless specifically agreed otherwise with given collaborators, and basing new branches on such known-PR sources from the fork is to accept that you might need to fix up your branches when they change and thats ok (I did that yesterday for $reasons, I had to rebase, that was fine). I wouldn't by default consider them the same thing as shared repo public feature branches like the Atlassian page discusses, which is more along the lines of someone made a feature branch in the lone shared public repo where everyone works. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
