cliffjansen commented on pull request #265: URL: https://github.com/apache/qpid-proton/pull/265#issuecomment-659671286
Very nice. +1 on the API. pn_raw_connection_free is not yet implemented in the pull request and the documentation about ownership of the raw connection is perhaps out of date, but I presume you are already aware. As an implementation detail, I wonder how you distinguish between an internal wake and an external pn_raw_connection_wake(), given that you have dispensed with the wake_count indicator (used for that purpose in the pconnection). For example, if an internal wake is generated in unassign_thread() within pni_raw_connection_done(), it seems to me you will get a spurious PN_RAW_CONNECTION_WAKE. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
