astitcher commented on pull request #265: URL: https://github.com/apache/qpid-proton/pull/265#issuecomment-659773351
> pn_raw_connection_free is not yet implemented in the pull request and the documentation about ownership of the raw connection is perhaps out of date, but I presume you are already aware. Actually it's the other way round - The current documentation is correct, and lack of ``pn_raw_connection_free()`` is my intention - the proactor takes ownership of the ``pn_raw_connection_t`` provided in ``pn_proactor_raw_connect()`` or ``pn_listener_raw_accept()`` and free it after the ``PN_RAW_CONNECTION_DISCONNECT`` event. > For example, if an internal wake is generated in unassign_thread() within pni_raw_connection_done(), it seems to me you will get a spurious PN_RAW_CONNECTION_WAKE. This might be something I missed in that case - can you expand on the situations when you might get an internal wake? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
