jiridanek commented on pull request #684: URL: https://github.com/apache/qpid-dispatch/pull/684#issuecomment-660637421
I've been thinking about this some: Support for RHEL 6 / CentOS 6 by the vendor ends at the end of this year (2020) and it is possible to get a C++11 compatible compiler from Software Collections (there is gcc 4.8, if I recall correctly), even on CentOS 6. Therefore, I'd go for doctest 2.4.0, instead for the C++98 compatible branch. I'd merge this in two stages. I am unsure about the mocking part, personally. So I'd merge the nonmocking part first, and add the rest later. I was thinking about merging #294 and I was thinking that it deserves to have a test. Then I realized we still don't have the doctest PR merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
