jiridanek commented on pull request #684: URL: https://github.com/apache/qpid-dispatch/pull/684#issuecomment-662915480
I've changed it some more, see my commits * DISPATCH-1568 Update RuntimeChecks to work with C++ code Since we are not mocking, the tests can run under any kind of build, including ASan builds. That requires passing the asan compile args to C++ compiler. * DISPATCH-1568 c-unittests: replace #define with C++ const, use SUBCASEs more C++ is nice in that e.g. `const int size=5; int array[size]` is allowed. No need for #defines. * DISPATCH-1568 Add terminus_private.h to make the `static` method testable @kgiusti had some nice things to say about the _private.h convention, and I think it is a good match in this situation as well. Correct me if I am wrong. * DISPATCH-1568 Remove qpid-dispatch-testing library (mocking proposal) Since we aren't mocking (yet), we don't need to build a special version of the library for the tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
