[
https://issues.apache.org/jira/browse/DISPATCH-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248585#comment-17248585
]
ASF GitHub Bot commented on DISPATCH-1870:
------------------------------------------
jiridanek commented on a change in pull request #944:
URL: https://github.com/apache/qpid-dispatch/pull/944#discussion_r541929555
##########
File path: tests/friendship_pb2.py
##########
@@ -0,0 +1,377 @@
+# -*- coding: utf-8 -*-
Review comment:
The generated files (this one and the other one) are missing the Apache
license header, so RAT check fails. I suggest adding it to rat ignores; grpc
compiler might be able to add the header, but that is probably needless
complication to worry about, all the time.
##########
File path: README
##########
@@ -80,6 +80,10 @@ To install pip and Quart
- python3 get-pip.py
- pip3 install --user quart
+The gRPC system tests (tests/system_tests_grpc.py) use grpcio and protobuf
modules.
+To install them use:
+ - pip3 install --user grpcio protobuf
Review comment:
maybe add a script (or just command to this readme) that can be used to
regenerate the autogenerated .py files
##########
File path: .travis.yml
##########
@@ -69,6 +69,8 @@ jobs:
- python -m pip install --user --upgrade tox virtualenv==20.0.23
# Install quart to run the http2 tests.
- python -m pip install --user quart
+ # Install grpcio and protobuf to run the grpc tests.
+ - python -m pip install --user grpcio protobuf
Review comment:
same thing needed for Github Action, (and any downstream CI there is)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add new system test to validate gRPC through HTTP2 adaptors
> -----------------------------------------------------------
>
> Key: DISPATCH-1870
> URL: https://issues.apache.org/jira/browse/DISPATCH-1870
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Reporter: Fernando Giorgetti
> Assignee: Fernando Giorgetti
> Priority: Major
>
> Implement a new system test to validate gRPC through the router HTTP2
> adaptors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
