[ 
https://issues.apache.org/jira/browse/DISPATCH-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272661#comment-17272661
 ] 

ASF GitHub Bot commented on DISPATCH-1870:
------------------------------------------

jiridanek commented on a change in pull request #944:
URL: https://github.com/apache/qpid-dispatch/pull/944#discussion_r565112575



##########
File path: README
##########
@@ -80,6 +80,10 @@ To install pip and Quart
  - python3 get-pip.py
  - pip3 install --user quart
 
+The gRPC system tests (tests/system_tests_grpc.py) use grpcio and protobuf 
modules.
+To install them use:
+  - pip3 install --user grpcio protobuf

Review comment:
       looks good; that does not add the copyright header, though, if I 
understand correctly
   
   ok, I see you excluded the generated files from rat check




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Add new system test to validate gRPC through HTTP2 adaptors
> -----------------------------------------------------------
>
>                 Key: DISPATCH-1870
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1870
>             Project: Qpid Dispatch
>          Issue Type: Test
>          Components: Tests
>            Reporter: Fernando Giorgetti
>            Assignee: Fernando Giorgetti
>            Priority: Major
>
> Implement a new system test to validate gRPC through the router HTTP2 
> adaptors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to