[
https://issues.apache.org/jira/browse/DISPATCH-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273840#comment-17273840
]
ASF GitHub Bot commented on DISPATCH-1870:
------------------------------------------
fgiorgetti commented on pull request #944:
URL: https://github.com/apache/qpid-dispatch/pull/944#issuecomment-769215412
Updated to use type hints instead.
On Thu, Jan 28, 2021 at 1:21 PM Jiri Daněk <[email protected]> wrote:
> *@jiridanek* commented on this pull request.
> ------------------------------
>
> In tests/friendship_server.py
> <https://github.com/apache/qpid-dispatch/pull/944#discussion_r566225862>:
>
> > +import grpc
>
> +
>
> +from friendship_pb2 import Person, CreateResult, PersonEmail,
CommonFriendsResult, FriendshipResponse
>
> +from friendship_pb2_grpc import FriendshipServicer,
add_FriendshipServicer_to_server
>
> +
>
> +
>
> +class FriendShipService(FriendshipServicer):
>
> + """
>
> + Implementation of the gRPC FriendshipServicer.
>
> + See the friendship.proto definition for more info.
>
> + """
>
> + def __init__(self):
>
> + self.people = list()
>
> +
>
> + def Create(self, request, context):
>
> + person: Person = request
>
>
> We still have to be Python 2.7 compatible
> ⬇️ Suggested change
>
> - person: Person = request
>
> + person = request # type: Person
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/qpid-dispatch/pull/944#pullrequestreview-578507657>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ABYML4RMY6NM4UVEN2KHH5DS4GFI5ANCNFSM4UXNSQLQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add new system test to validate gRPC through HTTP2 adaptors
> -----------------------------------------------------------
>
> Key: DISPATCH-1870
> URL: https://issues.apache.org/jira/browse/DISPATCH-1870
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Affects Versions: 1.15.0
> Reporter: Fernando Giorgetti
> Assignee: Fernando Giorgetti
> Priority: Major
> Fix For: 1.15.0
>
>
> Implement a new system test to validate gRPC through the router HTTP2
> adaptors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
