[
https://issues.apache.org/jira/browse/DISPATCH-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274470#comment-17274470
]
ASF GitHub Bot commented on DISPATCH-1870:
------------------------------------------
jiridanek commented on a change in pull request #944:
URL: https://github.com/apache/qpid-dispatch/pull/944#discussion_r566856960
##########
File path: tests/system_tests_grpc.py
##########
@@ -0,0 +1,215 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+import os, sys
+from time import sleep, ctime
+import system_test
+from system_test import TestCase, Qdrouterd, QdManager, Process, SkipIfNeeded,
TIMEOUT
+from subprocess import PIPE
+try:
+ import grpc
+ import friendship_server as fs
+ from friendship_pb2_grpc import FriendshipStub
+ from friendship_pb2 import Person, FriendshipRequest, PersonEmail
+except ImportError:
+ pass
+
+
+def skip_test():
+ """
+ If grpc cannot be imported, test must be skipped
+ :return:
+ """
Review comment:
Created https://github.com/apache/qpid-dispatch/pull/1006 to fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add new system test to validate gRPC through HTTP2 adaptors
> -----------------------------------------------------------
>
> Key: DISPATCH-1870
> URL: https://issues.apache.org/jira/browse/DISPATCH-1870
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Affects Versions: 1.15.0
> Reporter: Fernando Giorgetti
> Assignee: Fernando Giorgetti
> Priority: Major
> Fix For: 1.15.0
>
>
> Implement a new system test to validate gRPC through the router HTTP2
> adaptors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
